Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create: add --python option #6485

Merged
merged 3 commits into from
Sep 25, 2019
Merged

create: add --python option #6485

merged 3 commits into from
Sep 25, 2019

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Sep 24, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Another PR that adds new option to create command. This time it's --python.

@jonchang
Copy link
Contributor

Perhaps there could be an example resource block (commented-out?) that would help guide how virtualenv_install_with_resources can be used with Python dependencies?

@dawidd6
Copy link
Member Author

dawidd6 commented Sep 25, 2019

@jonchang agreed, was thinking about it earlier. Change committed.

MikeMcQuaid
MikeMcQuaid reviewed Sep 25, 2019
View reviewed changes
Library/Homebrew/formula_creator.rb Outdated
@@ -134,7 +150,7 @@ def install
"--prefix=\#{prefix}"
# system "cmake", ".", *std_cmake_args
<% end %>
<% if mode != :meson and mode != :go %>
<% if mode != :meson and mode != :go and mode != :python %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just if autotools || cmake at this point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this definitely looks better. Committed.

@MikeMcQuaid MikeMcQuaid merged commit 1279bba into Homebrew:master Sep 25, 2019
@MikeMcQuaid
Copy link
Member

Great work again @dawidd6. I look forward to your next PRs 😄

@dawidd6
Copy link
Member Author

dawidd6 commented Sep 25, 2019

Thanks @MikeMcQuaid! Next PR should arrive soon.

@dawidd6 dawidd6 deleted the create-python branch September 25, 2019 12:23
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidd6 @jonchang @MikeMcQuaid